Repository navigation
Windows x64 support and CI-built releases - #2
Merged
Merged
Conversation
- main.cpp: Windows Ctrl+C/Ctrl+Break shutdown via SetConsoleCtrlHandler; the POSIX sigwait path is unchanged. - CMake: static MSVC runtime, no MSVC OpenMP, /utf-8; version 0.2.0. - Tests: portable temp-dir helper replaces mkdtemp; the symlink case is optional where Windows refuses symlinks. e2e.sh runs under Git Bash. - scripts/download-default-model.cmd (curl.exe + certutil, SHA-256 check). - packaging/windows: start-server.cmd and README-windows.txt for the zip. - GitHub Actions: build, test (incl. [native] and e2e against the default model) on windows-latest and macos-14; v* tags publish the Windows zip and macOS tarball to the GitHub Release. - README: Windows prebuilt and build-from-source instructions, WSL 2 fallback, SmartScreen note. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
llama.cpp passes u8 literals as const char *, which fails under MSVC C++20. GitHub's macOS runners expose a paravirtualized Metal GPU whose results break cold-vs-cached equality checks that pass on real Apple Silicon (also with the release flags), so that job runs only the non-native tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
path::native() is a wide string on Windows, so the ".." prefix check did not compile there; comparing the first component is portable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
windows.h brings a GUID operator== into scope that makes json == string_view ambiguous under MSVC. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds native Windows x64 support so students can run PCD Server on Windows, and moves release builds into GitHub Actions.
Changes
SetConsoleCtrlHandler; the POSIXsigwaitpath is untouched.vcomp140.dll),/utf-8. Version 0.2.0.mkdtemp; the symlink case tolerates Windows refusing symlinks.tests/e2e.shruns under Git Bash.scripts/download-default-model.cmd(built-incurl.exe+certutil).pcd_server.exe,start-server.cmd, the download script,README-windows.txtand license files. The model is not bundled.[native]and e2e against the default model. Av*tag publishes both packages to the Release.Verification
PCD_TEST_GGUF) andtests/e2e.shpass locally; SIGTERM shutdown verified.🤖 Generated with Claude Code