group_reduce() - #224
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new group_reduce() API to ArrayKit’s C extension for fast per-group reductions over dense factorized codes, exposing it through the Python package and validating behavior via a dedicated test suite.
Changes:
- Implement
group_reduce()insrc/methods.cand export it via the extension module method table. - Expose
group_reduce()in the Python package (__init__.py) and type stubs (__init__.pyi). - Add unit tests covering basic behavior, dtype handling, NaN propagation, immutability, equivalence to NumPy, and error cases.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_group_reduce.py | Adds unit tests for group_reduce() across ops, dtypes, NaN behavior, and error handling. |
| src/methods.h | Declares the new group_reduce C-extension entry point. |
| src/methods.c | Implements grouped reductions for float64/int64 and count, with input validation and immutable outputs. |
| src/_arraykit.c | Registers group_reduce in the module method table. |
| src/init.pyi | Adds the public typing stub for group_reduce. |
| src/init.py | Exposes group_reduce at the package top level. |
| README.rst | Documents group_reduce() under “What is New”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.