Skip to content

[TASK][MVP] Verify the Complete SFP Contract Surface - #46

Merged
Noam-Alum merged 7 commits into
mvp/implementationfrom
mvp/sfp-contract-verification
Oct 27, 2026
Merged

Noam-Alum merged 7 commits into
mvp/implementationfrom
mvp/sfp-contract-verification

Conversation

@Noam-Alum

Copy link
Copy Markdown
Member

Required result

Outcome and ownership

Verify that the complete local SFP transport and generic-operation contract package can be consumed independently by Agent and Provider developers. This is Protocol integration/conformance work, not business-operation or runtime implementation.

Required behavior

  • Verify bootstrap, manifest, capability assessment, triggers, generic operation admission, lifecycle/progress/results/cancellation, and reconnect/recovery compose coherently. Identifier ownership, session/generation validation, versioning, error taxonomy, retention, and replay semantics must agree.

  • Prove SFP transports arbitrary declared operations through their own typed payload/result schemas without interpreting application meaning. Backup preparation, restore, disaster recovery, and BackupEngine behavior are not SFP procedures or Protocol-owned schemas.

  • Preserve landed bootstrap and manifest contracts. Keep operations as versioned namespaced strings, retain generic implements declarations without assigning Protocol-owned backup/DR meaning, and document only the current active contract.

  • Supply reusable conformance fixtures for ordinary operations, invalid schemas/results, duplicate/conflicting admission, progress/cancellation, trigger replay, channel loss, and state-loss recovery.

  • Check Buf lint, reproducible generation, generated-source freshness and compatibility. Generated modules must never be hand-edited. Ensure required protobuf/schema fixtures, typing markers, and documentation are included in wheel and sdist.

  • Verify clean installation/imports and dependency compatibility for supported Python versions/platforms. Separate build tooling from runtime dependencies and build strict documentation.

  • Maintain a machine-checked coverage inventory mapping every SFP procedure to its packaged conformance assets and standard CI entry points; missing procedure coverage is a release-blocking failure.

Acceptance evidence

CI/CD evidence must prove every planned SFP procedure is represented in the exact wheel and sdist and is executed by the full contract matrix.

All configured Protocol gates pass, installed-package consumers load every generic SFP service/schema/fixture, and independent Agent/Provider test peers make the same transport, validation, identity, idempotency, and recovery decisions. No fixture requires knowledge of BackupEngine or a predefined backup/DR operation.

Non-goals

No Agent/Provider runtime, business-operation catalogue, backup/DR schema, BackupEngine implementation, SF-AOP design, or Control Plane contract.

Compatibility, discretion, and delivery

Preserve landed contracts, public APIs, and repository boundaries. Current code wins existing disagreements with prose. Choose compatible implementation details from the current codebase and document tradeoffs for human review. Implement only the assigned Issue. Add behavioral tests and applicable repository checks/docs. Scoped local commits are allowed; a human pushes, opens the PR, reviews, and merges. Only matching merged GitHub evidence reconciled by DPT completes this step.

Canonical validation completion gate

  • Complete one public, procedure-owned validation API for every custom SFP v1 procedure with context-independent message or exchange semantics. Preserve Bootstrap, Manifest, and Capability APIs; backfill Trigger Publication, Operation Admission, Operation Lifecycle, and recovery additions.
  • Keep normative values in contract.py, domain validation in public validation.py, and only generic mechanics in private sfp._validation. Standard gRPC Health remains the documented exception and must not gain a duplicate service or validator for symmetry.
  • Verify architecture rules and installed artifacts, then audit Agent and Provider to prove they use public validators and never private helpers or equivalent local validation.

Implementation step

P9

Closes #45

@Noam-Alum Noam-Alum self-assigned this Oct 27, 2026
@Noam-Alum
Noam-Alum merged commit f79b2a1 into mvp/implementation Oct 27, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant