stashdb-performer-gallery: fix infinite loop in relink_images when performer has >100 images - #775
Open
adtdev20 wants to merge 1 commit into
Open
stashdb-performer-gallery: fix infinite loop in relink_images when performer has >100 images#775adtdev20 wants to merge 1 commit into
adtdev20 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Page number and Item counter were being set to the same variable, so when a performer had more than 100 images, the loop would jump from page 1 to page 100. With page 100 not having any content, it would drop back to 0, and read 0+1, so page 1 again, and just get stuck there indefinitely.
The code in tagImagesFromGalleries correctly handled the count + pagination so that's the template for this fix.