Repository navigation
Conversation
Table columns were described by the private fields of LinkedHashMap. The column of a regular index, a table primary key, and a collection's lexical analyzer were described as objects only, though each also accepts a string.
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Four MCP tool arguments had input schemas that describe JSON the server does not accept. The column and field maps of
createTable,alterTable,createType, andalterTypelistedaccessOrder,loadFactor, andthreshold, which are private fields ofLinkedHashMap. ThecolumnofcreateIndex, theprimaryKeyofcreateTable, and the lexicalanalyzerofcreateCollectionwere typed as objects only, though each also accepts a string.McpSchemaCustomizernow describes a class that extends a map as a JSON object. It also readsanyOfandoneOffrom a field's@Schema, which Swagger already reads.primaryKeyandanalyzercarried those annotations already, andRegularIndexDefinitionDesc.columngains one. The command parsing is unchanged.Which issue(s) this PR fixes:
Part of #2604
Verification
McpSchemaShapeContractTestparses each example with the server's own deserializer and validates it against the published tool schema. Its table and index tests failed on main for the reasons above, and all 13 pass with the change. The command below ran 131 tests with no failures or skips on JDK 25. TheQuarkusIntegrationTestschema suite was not run locally.One open question. The OpenAPI document still describes each table column type as an object with an
apiNameproperty. I left that alone because it changes the Swagger output and is not needed for the MCP schemas.Checklist