Repository navigation
Conversation
MeteredCommandProcessor builds the filter and sort clauses again to choose the sort_type tag. A clause the command already rejected throws again there, which replaced the error result with a failed Uni and skipped the timer. MCP reported that as a JSON-RPC internal error.
Contributor
📉 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
A command with an invalid filter or sort clause now returns its error result through MCP. Before this change the MCP client received a bare JSON-RPC
Internal error, and the command timer was never recorded for these requests on either API.CommandProcessoralready turns the clause failure into an error result.MeteredCommandProcessorthen builds the filter and sort clauses a second time to choose thesort_typemetric tag, and the same exception is thrown again from the success callback. That replaced the error result with a failedUni. The HTTP API hid this because its exception mapper still produced the error body. The tag now falls back toNONEwhen a clause cannot be built, so the result and the timer are kept.Which issue(s) this PR fixes:
Fixes #2680
Verification
The new test failed before the fix with
Unsupported filter operator '$bogus'and passes after it. It checks that the processor returns the same error result and that the timer carries the filter error code andsort_type="NONE". The command below ran 125 tests with no failures or skips on JDK 25. I found the problem by callingfindthrough MCP against DSE 6.9.21, but I have not repeated that call against this branch.One open question.
NONEis the tag for a request with an invalid clause because no sort was applied. A separate value such asINVALIDwould be more exact but adds a metric tag value.Checklist