fix(governance): pin UTC review dates and classify baseline evidence - #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
last_reviewedagainstdatetime.now(timezone.utc).date().reposentinel-baseline.jsonunchanged and the remote gate non-blockingDesign decision
Use an explicit UTC date provider for provenance validation. Tests inject a fixed clock for the Taipei/UTC boundary instead of depending on the runner's current date. The baseline review records classifications and tool provenance without copying raw token values.
Main risk
The v0.8 repo-sentinel audit input is from a development-line commit, not a released dependency. The report therefore records evidence and defers remote-gate enablement. One active
repo.required_file_missingentry forLICENSEremains an unresolved repository-governance condition.Compatibility impact
Existing pattern metadata remains valid. The only behavior change is that future-date validation is now consistently UTC-based across local and CI runs. No baseline entries are added, removed, or rewritten.
Rollback path
Revert the governance documentation commit, the contract-test commit, and the UTC behavior commit. This has no schema migration or persisted-data impact. A future remote job can be removed independently while retaining the local hook.
Verification
python -m unittest discover -s tests -p 'test_*.py'python scripts/check_pattern_library.pypython scripts/render_tags_doc.py --checkpython scripts/render_readme_snapshot.py --checkpython scripts/check_placeholders.pypython scripts/check_markdown.pypython -m pre_commit run --files ...npx --no-install markdownlint-cli2 docs/README.md docs/reviewer-brief.md docs/repo-sentinel-baseline-review.md patterns/README.md