Skip to content

feat(scf): onboard scf space command - #1721

Open
SerseusWasTaken wants to merge 1 commit into
mainfrom
feat/scf-space-resource
Open

SerseusWasTaken wants to merge 1 commit into
mainfrom
feat/scf-space-resource

Conversation

@SerseusWasTaken

Copy link
Copy Markdown
Contributor

Description

Onboards the SCF space functionality

Relates to STACKITCLI-483

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@SerseusWasTaken
SerseusWasTaken requested a review from a team as a code owner November 2, 2026 12:22
Relates to STACKITCLI-483
@SerseusWasTaken
SerseusWasTaken force-pushed the feat/scf-space-resource branch from e9ecaf3 to 67c9517 Compare November 2, 2026 13:13
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

Merging this branch changes the coverage (1 decrease, 7 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/organization/role/set 58.97% (-0.55%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/platform/list 65.38% (+2.64%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/create 55.26% (+55.26%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/delete 45.16% (+45.16%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/describe 69.77% (+69.77%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/list 74.00% (+74.00%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/role 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/role/set 56.10% (+56.10%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/update 53.85% (+53.85%) 🌟
github.com/stackitcloud/stackit-cli/internal/pkg/services/scf/utils 100.00% (ø)
Coverage details

Compared to commit 076aecd (run #41446980271)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/organization/role/set/set.go 58.97% (-0.55%) 39 (-3) 23 (-2) 16 (-1) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/platform/list/list.go 65.38% (+2.64%) 52 (+1) 34 (+2) 18 (-1) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/scf.go 0.00% (ø) 6 (+1) 0 6 (+1)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/create/create.go 55.26% (+55.26%) 38 (+38) 21 (+21) 17 (+17) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/delete/delete.go 45.16% (+45.16%) 31 (+31) 14 (+14) 17 (+17) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/describe/describe.go 69.77% (+69.77%) 43 (+43) 30 (+30) 13 (+13) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/list/list.go 74.00% (+74.00%) 50 (+50) 37 (+37) 13 (+13) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/role/role.go 0.00% (ø) 4 (+4) 0 4 (+4)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/role/set/set.go 56.10% (+56.10%) 41 (+41) 23 (+23) 18 (+18) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/space.go 0.00% (ø) 9 (+9) 0 9 (+9)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/update/update.go 53.85% (+53.85%) 39 (+39) 21 (+21) 18 (+18) 🌟
github.com/stackitcloud/stackit-cli/internal/pkg/services/scf/utils/utils.go 100.00% (ø) 29 (+23) 29 (+23) 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files:

  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/platform/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/role/set/set_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/scf/space/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/scf/utils/utils_test.go

params := testparams.NewTestParams()
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if err := outputResult(params.Printer, tt.model, "space", tt.resp); (err != nil) != tt.wantErr {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tt.outputFormat unused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants