Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Regular Expression Conversion Problem with the Rules Converter #29

Description

@x1angli

Thanks for this wonderful tool.

I found a minor issue when using The Rules Converter. Say if I have a dnsmasq conf file written like
server=/.blogspot.com/8.8.8.8

it means I want blogspot.com along with its subdomains to be resolved by 8.8.8.8.

The correct conversion should be sth like
[ { "Pattern": "^(.*\\.)?blogspot\\.com$", "NameServer": "8.8.8.8" } ]

However, the current converter adds extra '\\.' in the URL, yielding
[ { "Pattern": "^(.*\\.)?\\.blogspot\\.com$", "NameServer": "8.8.8.8" } ]
so that the rule won't work as expected.

The converter might deal with such edge case more properly. Thanks

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions