Skip to content

fix: Correct the SBOM scoping follow-ups from #1630 - #1635

Merged
dervoeti merged 1 commit into
mainfrom
fix/sbom-followups
Sep 10, 2026
Merged

fix: Correct the SBOM scoping follow-ups from #1630#1635
dervoeti merged 1 commit into
mainfrom
fix/sbom-followups

Conversation

@dervoeti

Copy link
Copy Markdown
Member

Description

Follow-up to #1630. While verifying the resulting image SBOMs, a few of the changes there turned out
to be incomplete, ineffective or to have removed too much.

OpenSearch Dashboards: --target yarn is not a cdxgen option, cdxgen silently ignored it and auto-detected every ecosystem in the source tree, so the GitHub Actions workflows and the Gradle and Python files of the build tooling ended up in the SBOM.

Kafka 4.1.1 and 4.2.1: includeConfigs now also contains releaseOnly, a few components were shipped without being in the SBOM.

Kafka (all versions): additionally skips generator, the integration test projects and connect:test-plugins.

OpenSearch 3.1.0 and 3.4.0: additionally skip build-tools and the remaining unshipped projects (sandbox, docs, doc-tools, rest-api-spec, the client benchmarks and client:sniffer).

Airflow and Superset: the purl fix from #1630 only covered the Airflow and Superset packages themselves. It now applies to every package without a purl (opa-auth-manager, opa-authorizer, pip), and the names in all pypi purls are normalized as defined in the Python packaging specification. cyclonedx-py keeps the name as written in the metadata (pkg:pypi/zope.event) while Syft normalizes it (pkg:pypi/zope-event), which was another source of duplicates in the image SBOM.

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

boil build <IMAGE> --image-version <RELEASE_VERSION> --strip-architecture --load
kind load docker-image <MANIFEST_URI> --name=<name-of-your-test-cluster>

See the output of boil to retrieve the image manifest URI for <MANIFEST_URI>.

@dervoeti dervoeti moved this to Development: Waiting for Review in Stackable Engineering Sep 10, 2026
@dervoeti dervoeti self-assigned this Sep 10, 2026
@NickLarsenNZ
NickLarsenNZ self-requested a review September 10, 2026 12:15
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 10, 2026

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread airflow/Dockerfile
@dervoeti
dervoeti added this pull request to the merge queue Sep 10, 2026
Merged via the queue into main with commit d3f3d4f Sep 10, 2026
3 checks passed
@dervoeti
dervoeti deleted the fix/sbom-followups branch September 10, 2026 12:44
@NickLarsenNZ NickLarsenNZ moved this from Development: In Review to Development: Done in Stackable Engineering Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

3 participants