Repository navigation
Add Trino Unit testcoverage and fix minor bugs - #374
Open
Bohreromir wants to merge 10 commits into
Open
Bohreromir wants to merge 10 commits into
Bohreromir wants to merge 10 commits into
Conversation
Unit tests for the query, catalog and completion metadata endpoints: request validation, connection checks, generated SQL including identifier and literal escaping, result mapping and error status codes.
Covers sequential script execution and stop conditions, cancellation, snapshots, tab removal and the TTL-based eviction sweep.
- Count a submit without query ID as failed, so trino_query_total stays balanced. - Don't expose a terminal state straight from the submit response. The query previously skipped draining any remaining pages and never got a completion time or outcome metric.
…345) While a script waited for Trino to accept its next statement, the tab had no active query: cancelling did nothing, and a re-run's results were mixed with those of the old script, which kept executing. Track the running script per tab with an AbortController. cancelQuery, resetTabQueries and a new script abort it; a statement accepted after the abort is cancelled in Trino instead of stored. Cancellation now updates state synchronously before calling Trino, so concurrent callers cannot cancel or count a query twice and a reset cannot wipe a newer script.
Mapping terminal submit states to RUNNING turned a FAILED response without an error object into a completed query, and the script went on to the next statement.
collectResults only failed a query when the page carried an error object. A FAILED state without one was ignored and the query ended as FINISHED.
Bohreromir
changed the title
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
lfrancke
previously approved these changes
Oct 9, 2026
lfrancke
left a comment
lfrancke
left a comment
Member
There was a problem hiding this comment.
I only lazily scrolled through this and let Claude do a review. As this is only test code I think it's okay. I didn't spot anything obvious.
lfrancke
previously approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.