Fix: Region updates and URL changes for NinjaOne plugin - #77
Conversation
📝 WalkthroughWalkthroughUpdated NinjaOne regional API base URL hostnames in ChangesNinjaOne endpoint and version update
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Switches US/US2/CA/OC to the documented app./us2./ca./oc.ninjarmm.com hostnames instead of the api./-api variants, matching the same fix already applied to EU to avoid the same class of region-URL issue. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
🧩 Plugin PR Summary📦 Modified Plugins
📋 Results
🔍 Validation Details✅
|
|
Are we able to test this change with other regions or confident this will work as expected? |
|
@fionawhite i vote to merge this now, then we can move the plugin when this fix is in place. Does that sound okay @vinbab ? |
Ok. In terms of testing, did you manage to confirm it's still working in the other regions? Looks like there's also an outstanding comment above from Vincent about the title and description. |
@vinbab @fionawhite Sorry missed this comment! I have now updated the PR title to be more accurate for all URL changes we are making here. Unfortunately we don't have all of these NinjaOne regions to test against. However, I have verified that any region URLs we are changing resolve to the exact same IP address range as the old URLs. This means that even though we are updating the URLs they point to the exact same API and wont break anything for existing users. |
📋 Summary
Quite a simple region change for the EU region for the NinjaOne plugin. This does not break existing EU region customers as the new/changed URL resolves to the same API. This change is needed though as some NinjaOne customers do require eu.ninjarmm.com. The existing eu-api.ninjarmm.com URL that the plugin uses is an alias that seemingly not all customers can use.
I have also updated the other regions so they use this newer URL format from NinJaOne. Although we do not have every region to test against, I have verified that any updated URLs do resolve to the same IP addresses as the previous, so they hit the same APIs which wont break anything for existing users.
🔗 Related issue(s)
https://squaredup-eng.atlassian.net/browse/PLUG-4662
🧩 Plugin details
Does this PR introduce any breaking changes?
If yes, describe:
📚 Documentation
✅ Checklist
Summary by CodeRabbit