ci: run required checks for merge queue groups - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
merge_group: types: [checks_requested]to the SQLx CI workflow so required checks run against the temporary commits created by the merge queue.Diagnosis
The main ruleset requires six SQLx checks and has a 60-minute check-response timeout. The workflow only handled pull requests and pushes to main, so queue commits received no checks and PRs were removed with
checks_timed_out. GitHub reported zero merge-group workflow runs before this fix.Validation
git diff --checkpassed.