fix(macros): use oldapi crate paths for SQLite string enums - #70
Merged
Merged
Conversation
lovasoa
enabled auto-merge
September 27, 2026 23:15
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deriving
sqlx_oldapi::Typefor a string enum with the SQLite feature fails unless an extrasqlxalias happens to be in scope: three generated paths still refer to the upstream crate name. This can also break enum derives for other databases when SQLite is enabled alongside them.Use
::sqlx_oldapiconsistently, and add a SQLite string-enum round-trip regression test without a sqlx alias.Validation: the new test reproduced E0433 before the fix; both SQLite enum tests pass afterward, including prepared and unprepared encode/decode checks. The PostgreSQL derive test target also compiles with all database and type features enabled. Formatting and diff checks passed. All Cargo commands used the committed lockfile.