fix(sqlite): return an error for out-of-range timestamps - #65
Merged
Merged
Conversation
lovasoa
enabled auto-merge
September 27, 2026 23:28
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decoding a SQLite integer outside time's timestamp range as
PrimitiveDateTimecurrently panics insidetry_get/query_scalar, rather than returning a decoding error. Propagate the existing range error, matching theOffsetDateTimedecoder.The regression test reads
i64::MINandi64::MAX, checks the resultingColumnDecodeerror and underlyingComponentRange, then verifies valid timestamps still decode on the same connection.Validation: reproduced the panic with the regression test before the fix; all five SQLite time integration tests pass afterward. Formatting passes. Tests used Rust 1.98.1 and the committed lockfile, with system OpenSSL. The pre-existing Clippy deprecations are handled independently by #62.