fix(odbc): populate the statement params and cache on the query path - #61
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
81reap
force-pushed
the
81reap/odbc-params-and-cache
branch
from
September 25, 2026 05:14
d613ca0 to
48dd128
Compare
81reap
changed the title
Collaborator
|
@81reap could you build sqlpage against this version of sqlx and try it against duckdb ? report if it works, if it's faster / slower. I care about duckdb (which has actual sqlpage production users) more than gizmosql |
Author
|
yes, my clanker said that it did work this morning but I haven't personally tested it yet. Was gonna do that when I get home from work |
`Executor::fetch_many` only ever read `stmt_cache`, so `statement_cache_capacity` and `Execute::persistent()` were empty and all queries ran through SQLExecDirect. `execute_stream` cannot borrow `&mut self`, so prepared satements weren't processed correclty. Now `execute_steam` is async and a query with arguments runs as a prepared statement, which fixes drivers taht ignore values bound before `SQLExecDirect`. Raw SQL still executes directly.
81reap
force-pushed
the
81reap/odbc-params-and-cache
branch
from
September 26, 2026 17:21
48dd128 to
aa71a17
Compare
81reap
marked this pull request as ready for review
September 26, 2026 17:22
lovasoa
approved these changes
Sep 27, 2026
lovasoa
enabled auto-merge
September 27, 2026 23:14
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executor::fetch_manyonly ever readstmt_cache, sostatement_cache_capacityandExecute::persistent()were empty and all queries ran through SQLExecDirect.execute_streamcannot borrow&mut self, so prepared satements weren't processed correclty.Now
execute_steamis async and a query with arguments runs as a prepared statement, which fixes drivers taht ignore values bound beforeSQLExecDirect. Raw SQL still executes directly.manual testing :: #57 (comment)