ci: pin Clippy to Rust 1.98.1 and clear warnings

.github/workflows/sqlx.yml

@@ -22,6 +22,10 @@ jobs:
         tls: [native-tls, rustls]
     steps:
       - uses: actions/checkout@v6
+      - name: Install pinned Clippy toolchain
+        uses: dtolnay/rust-toolchain@ce678459e9fc7500d337468f904b95f1b5c10b5e
+        with:
+          components: clippy
       - uses: Swatinem/rust-cache@65012b490220f477f20ab979e35ae732e6de4e68
         with:
           prefix-key: v1-sqlx

sqlx-core/src/logger.rs

@@ -51,7 +51,7 @@ impl<'q> QueryLogger<'q> {
 
             let sql = if summary != self.sql {
                 summary.push_str(" …");
-                format!("\n\n{}\n", &self.sql)
+                format!("\n\n{}\n", self.sql)
             } else {
                 String::new()
             };
@@ -125,7 +125,7 @@ impl<'q, O: Debug + Hash + Eq, R: Debug, P: Debug> QueryPlanLogger<'q, O, R, P>
 
             let sql = if summary != self.sql {
                 summary.push_str(" …");
-                format!("\n\n{}\n", &self.sql)
+                format!("\n\n{}\n", self.sql)
             } else {
                 String::new()
             };

sqlx-core/src/mssql/connection/stream.rs

@@ -342,7 +342,7 @@ pub(crate) fn write_packets<'en, T: Encode<'en>>(
             );
         }
 
-        packet_header.truncate(0);
+        packet_header.clear();
         PacketHeader {
             r#type: ty,
             status: if is_last {

sqlx-core/src/postgres/connection/sasl.rs

@@ -113,7 +113,7 @@ pub(crate) async fn authenticate(
     let client_final_message_wo_proof = format!(
         "{channel_binding},r={nonce}",
         channel_binding = channel_binding,
-        nonce = &cont.nonce
+        nonce = cont.nonce
     );
 
     // AuthMessage := client-first-message-bare + "," + server-first-message + "," + client-final-message-without-proof

sqlx-macros/src/query/output.rs

@@ -226,7 +226,7 @@ fn get_column_type<DB: DatabaseExt>(i: usize, column: &DB::Column) -> TokenStrea
                 if let Some(feature_gate) = <DB as DatabaseExt>::get_feature_gate(type_info) {
                     format!(
                         "optional feature `{feat}` required for type {ty} of {col}",
-                        ty = &type_info,
+                        ty = type_info,
                         feat = feature_gate,
                         col = DisplayColumn {
                             idx: i,

tests/postgres/types.rs

@@ -69,7 +69,7 @@ test_type!(str<&str>(Postgres,
 ));
 
 test_type!(string<String>(Postgres,
-    "'this is foo'" == format!("this is foo"),
+    "'this is foo'" == "this is foo".to_string(),
 ));
 
 test_type!(string_vec<Vec<String>>(Postgres,