Conversation
`noImplicitAny` is now enabled. Most of the remaining implicit workarounds rooted from `JSON.parse(data_element.textContent)`. This found 3 bugs due to `as ChartPoint` :: 1. `ChartPoint.x` excluded null, `z` was a number, and `y` excluded the `string[]` two `value` columns return. 2. `ChartSeries.name` was a string, and the test pinning a numeric series name has passed all along. 3. `merged_x_values` compares x values that may be null, which JavaScript reads as zero. Most remaining work arounds we should step back and think big about if we need to upstreaming patches along with the fixes.
81reap
added this pull request to stack #1512
September 30, 2026 04:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noImplicitAnyis now enabled.Most of the remaining implicit workarounds rooted from
JSON.parse(data_element.textContent).This found 3 bugs due to
as ChartPoint::ChartPoint.xexcluded null,zwas a number, andyexcluded thestring[]twovaluecolumns return.ChartSeries.namewas a string, and the test pinning a numeric series name has passed all along.merged_x_valuescompares x values that may be null, which JavaScript reads as zero.Most remaining work arounds we should step back and think big about if we need to upstreaming patches along with the fixes.
Stack created with GitHub Stacks CLI • Give Feedback 💬