Preserve async API version resolver order - #37096
Open
Gimini-3 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Gimin Kim <138752849+Gimini-3@users.noreply.github.com>
Gimini-3
marked this pull request as ready for review
July 31, 2026 14:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes reactive API version resolution so that resolver registration order is honored.
DefaultApiVersionStrategy.resolveApiVersioncurrently usesflatMap, which subscribes to resolver publishers concurrently. As a result,next()selects the first emitted value instead of the first non-empty resolver in the configured list. A later resolver can therefore win when it completes faster, and an error from an earlier resolver can be cancelled after a later resolver emits.This change uses
concatMapto subscribe to one resolver at a time. That matches the synchronousresolveVersionimplementation and the documented first-non-null resolver behavior.The added tests deterministically verify that:
The tests use
TestPublisherrather than wall-clock delays.Tests:
./gradlew :spring-webflux:test --tests org.springframework.web.reactive.accept.DefaultApiVersionStrategiesTests./gradlew :spring-webflux:check