Repository navigation
Conversation
Split the single `contentctl-ng test` step into `test plan` (run before Splunk is provisioned so planning errors fail fast) and `test run`. Provision Splunk via `install --provision` instead of a hand-rolled `docker run` + sleep, and upload testing_artifacts/, contentctl-ng logs, and the built package as job artifacts. Rewrite format_test_results.py to read the new testing_artifacts/test_results_*.yml format, ignore testing_artifacts/, and pin contentctl-ng to 1.2.0b1, the first version with test plan/run. Co-Authored-By: Claude Code <noreply@anthropic.com>
Adds a dummy reference URL to two detections so the CHANGED-mode test plan selects them. For testing the updated workflow only; revert this commit before taking the PR out of draft. Co-Authored-By: Claude Code <noreply@anthropic.com>
The install step runs against the base-branch checkout, whose requirements.txt still pins 1.1.1, so the PR's pin is never read. Hardcode 1.2.0b1 so this PR's run uses the new test plan/run commands. Revert this commit before merging. Co-Authored-By: Claude Code <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contentctl-ng teststep inunit-testing.ymlinto two commands:contentctl-ng test plan --test-type detection.unit --mode CHANGED --git-ref <base_ref>contentctl-ng test run --post-test-behavior NEVER_PAUSEtest plandoes not connect to Splunk, so it now runs before the slow Splunk provisioning step to fail fast on planning errors. (--post-test-behavioris atest runoption;test planrejects it.)contentctl-ng install --provisioninstead of the hand-rolleddocker run+sleep 180. It waits until the container is healthy.--verbose. The DEBUG log (contentctl_ng_*.log) is always written to the working directory.test_summary_resultsartifact:testing_artifacts/(plan, results YAML, JUnit XML),contentctl_ng_*.log, anddist/*.tar.gz. Upload still runs when tests fail.format_test_results.pyto read the newesttesting_artifacts/test_results_*.yml(the oldtest_results/summary.ymlno longer exists).testing_artifacts/to.gitignore.contentctl-ng==1.2.0b1inrequirements.txt, the first version withtest plan/test run.Notes
contentctl-ng 1.2.0b1must be published forpip install -r requirements.txtto succeed in CI.--provisionuses Docker Compose, so the runner needsdocker compose. Worth confirming onlarge-ubuntu-22.04-32corewith this run.Test plan
--provision, and run on this PRtest_summary_resultsartifact containstesting_artifacts/,contentctl_ng_*.logfiles, and thedisttarballformat_test_results.py22449d9a38,363e9630ad), then mark ready for review🤖 Generated with Claude Code