Skip to content

Fix technical errors and clarity issues in Drawing Using Procedures guide - #41

Open
stantheman96 wants to merge 1 commit into
splashkit:masterfrom
stantheman96:patch-3
Open

Fix technical errors and clarity issues in Drawing Using Procedures guide#41
stantheman96 wants to merge 1 commit into
splashkit:masterfrom
stantheman96:patch-3

Conversation

@stantheman96

@stantheman96 stantheman96 commented Aug 9, 2026

Copy link
Copy Markdown

Correct Python run commands, fix x/y coordinate wording, and improve grammar and clarity throughout the guide.

Description

Corrects technical and documentation issues in the Drawing Using Procedures guide, including incorrect Python run commands, incorrect x/y row-column wording, and several grammar and clarity issues.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (update or new)

How Has This Been Tested?

Reviewed the rendered GitHub preview and verified that the updated documentation displays correctly. Confirmed the Python commands now reference program.py and the x/y coordinate wording is corrected.

Checklist

I have performed a self-review of my own code
I have made corresponding changes to the documentation

Folders and Files Added/Modified

Please list the folders and files added/modified with this pull request and delete options that are not relevant.

src/content/docs/guides/graphics/drawing-using-procedures.mdx

Correct Python run commands, fix x/y coordinate wording, and improve grammar and clarity throughout the guide.
@stantheman96 stantheman96 changed the title docs: fix commands and wording in drawing procedures guide Fix technical errors and clarity issues in Drawing Using Procedures guide Aug 9, 2026

@Rhinoatron Rhinoatron left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work on this guide. The main technical fixes look correct: the Python run commands now reference program.py, and the x/y coordinate wording has been corrected so x maps to column and y maps to row.

I’d like to request a few small changes before approving:

  • Some useful code formatting/linking was removed while improving the wording. For example, close_all_windows(), fill_rectangle, draw_rectangle, COLOR_, and refresh_screen should stay formatted as code, and the Close Window API reference should ideally remain linked.
  • Could you please confirm the page has been checked in the local Starlight site, rather than only through GitHub’s rendered preview? GitHub preview does not always match the actual documentation site rendering.

I also checked for duplicate PRs touching this same guide and did not find another current duplicate.

Once those small documentation and rendering checks are addressed, I’ll be happy to take another look. Many thanks

@jankiluitel jankiluitel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the technical accuracy and clarity of the Drawing Using Procedures guide. The grammar improvements and the correction of the x/column and y/row explanation look good.

I noticed that the code-language section appears to contain two Python TabItems with the same skm python3 program.py command. Could you please check whether one of these tabs should be for another language or whether the duplicate should be removed?

Once that is confirmed/fixed, this looks good from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants