Repository navigation
test(daemon): stop reading the stub engine's argv before it is written - #264
Merged
Merged
Conversation
The stub engine wrote its argv with a shell redirection, which creates and truncates the file before printf writes to it. Tests that waited only for the file to exist could read it empty and fail. The stub now writes to a sibling file and renames it, and the wait helper waits for the text each test goes on to assert on, which also covers the engine log being opened before its first line is written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestCmdDaemon_StartCarriesDeployConfigfailed intermittently on CI because the daemon tests could read the stub engine's argv file while it was still empty. This removes the race.Summary
> fileredirection creates and truncates the file beforeprintfwrites, and a test that waited only for the file to exist could read it in between.waitForFilenow waits for non-empty content, and a newwaitForFileContainingwaits for the exact text a test goes on to assert on. The tests that read the engine log use it too, since the daemon opens the log before its first line is written and they had the same gap.Implementation details