Skip to content

chore(github): add copilot PR review instructions - #456

Merged
maxlambrecht merged 1 commit into
spiffe:mainfrom
maxlambrecht:chore/copilot-pr-review-instructions
Aug 7, 2026
Merged

chore(github): add copilot PR review instructions#456
maxlambrecht merged 1 commit into
spiffe:mainfrom
maxlambrecht:chore/copilot-pr-review-instructions

Conversation

@maxlambrecht

Copy link
Copy Markdown
Member

What

  • Add GitHub Copilot repository and path-scoped PR review instructions.
  • Cover general review quality, security, SPIFFE ID parsing, SVID/bundle validation, Workload API lifecycle, provider/helper behavior, build changes, docs/examples, and tests.

Why

  • Improve Copilot review signal for java-spiffe by grounding comments in repo-specific correctness, security, compatibility, and SPIFFE semantics.
  • Reduce noisy or speculative review comments by requiring concrete impact, evidence, and minimal fixes.

How tested

N/A

@maxlambrecht
maxlambrecht requested a review from rturner3 as a code owner August 5, 2026 17:52
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
@maxlambrecht
maxlambrecht force-pushed the chore/copilot-pr-review-instructions branch from aab97cf to 2e5a51b Compare August 7, 2026 13:16
@maxlambrecht
maxlambrecht merged commit 934d2a6 into spiffe:main Aug 7, 2026
8 checks passed
@maxlambrecht
maxlambrecht deleted the chore/copilot-pr-review-instructions branch August 7, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants