Repository navigation
fix(web-portal): handle escape characters - #8645
grantfitzsimmons wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthrough
ChangesWeb Portal export cell cleaning
Suggested reviewers: Priority: ⬆️ High Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The export cleanup has a focused test, and no specific failure requiring a fix before merge is established. 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
Full details: Testing InstructionsExplanation The PR description has an empty “Testing instructions” section. The diff changes
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #8644
This PR makes it so our Web Portal exports sanitize backslashes to doubles backslashes in exported cell values so any literal Java-style sequences such as
\\r,\\b, and\\fremain literal when processed by the portal.I tested this quite a bit with the UWFC Web Portal export. That worked perfectly after this change, but before was causing an error upon ingestion.
Checklist
self-explanatory (or properly documented)
specify7/specifyweb/specify/management/commands/run_key_migration_functions.py
Line 50 in ea04665
Testing instructions