Repository navigation
docs: keep each edit and Code Mode fact in one place - #222
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each fact below now has one source. The other places keep what the reader acts on and point to the source.
--constraintsmodesmops edit model --helpexplain/edit.txt,examples/pages/editing.json.md, KDoc ofConstraintEnforcement,MpsWrite.modelEdit,ConceptValidityGuardmops explain editexamples/pages/editing.json.md,skills/mops/SKILL.mdproject.commandsaves and revertsProject.commandcatalog entry (mops code help Project.command)examples/pages/editing.nodes.md,examples/pages/editing.md,skills/mops/SKILL.md, KDoc ofCodeModeExtensions.commandskills/mops-daemon/SKILL.mdexamples/pages/validation.mddocs/daemon-request-concurrency.mddocs/test-running-design.mdexamples/pages/editing.mdsaid Code Mode commands "do not roll back partial edits on an exception".CodeModeExtensions.commandreloads every changed model on failure, so that line now points tomops code help Project.commandtoo.skills/mops/SKILL.mdkeeps "modules and models it created and module changes remain after a failure", because theProject.commandentry does not say it yet.Left as is:
CodeCatalog.kt(theProject.commandentry and the header line that repeats it), because feat: add missing used languages and model imports in Code Mode commands #214 changes them.docs/test-running-design.md, which names thetest-system-cache/<MPS build number>/workerpath as part of the test worker design.Generated pages under
docs/reference/andskills/mops/references/are regenerated.Evidence
./gradlew :cli:checkReference :cli:checkExamples :cli:test --tests '*ExamplesCommandTest' --tests '*CommandHelpTest': passes.prek run --files <changed files>: passes.Merge Danger
Blast Radius: docs
Open PRs that edit the same files and will need to merge
main:explain/edit.txt,examples/pages/editing.json.md,ConstraintEnforcement.kt,MpsWrite.kt,ConceptValidityGuard.kt, generated edit pagesexplain/edit.txt,examples/pages/editing.json.md,examples/pages/editing.nodes.md,skills/mops/SKILL.md,CodeModeExtensions.kt, generated pagesexamples/pages/validation.md,skills/mops/references/validation.md,docs/test-running-design.mddocs/test-running-design.md