Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @alukach's task in 9s —— View job ✅ No blocking issues — safe to merge. The diff has no correctness or security problems.
I read the diff only. I did not build the project or run the tests. Simplify (ponytail)
💰 Estimated review cost: $0.11 · 0m09s · 4 turns |
Contributor
|
Docs preview: https://cli.source.coop/pr-preview/pr-99/ Built from 350b575. It goes live a minute or two after this run, once GitHub Pages deploys it, and is removed when the PR closes. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
source-coop creds --format env(andauth login --no-cache --format env) now also points the AWS SDKs and CLI at the data proxy for the selected--proxy-url. Aftereval,aws s3 ls s3://ACCOUNT/PRODUCT/works with no--endpoint-url,--regionor profile.How it behaves
After the three credential exports,
--format envprints:AWS_ENDPOINT_URL_S3/_STS, not the globalAWS_ENDPOINT_URL. The global one would send IAM, and every other service, to the proxy too./on--proxy-urlis dropped, so STS is never…//.sts.service-account usagealready printed for API keys; both now come from one helper,output::endpoint_env.credential-process,aws-credentials) are unchanged, and so are exit codes.Not breaking in practice: a script that
evals these and then calls real AWS was already failing, since source.coop's keys aren't valid there. Only S3 and STS move.Who honours
AWS_ENDPOINT_URL_S3: AWS CLI v2 (2.13+), boto3 (1.28+), s3fs, obstore / object_store and polars. GDAL and DuckDB don't (see below).Demos
These run against
docs/recorder/stub.py, not a real environment: the recorder draws the stub's URLs assource.coop/data.source.coopand the throwawayHOMEas~. The credentials are made up.eval $(source-coop creds --format env), then aws s3 ls with no other flags
The README's
awsdemo (docs/demos/aws.svg) is re-recorded to end with the sameevaland a flaglessaws s3 ls.Docs changes
aws s3 lsafter theeval, and which tools readAWS_ENDPOINT_URL_S3.awsdemo.Not in this PR
AWS_ENDPOINT_URL_S3. Separate PRs add--format gdal-envand--format duckdbfor them.AWS_ENDPOINT_URL, for the reason above.Testing
cargo fmt,cargo clippy --all-targets -- -D warnings,cargo testandcargo test --features stagingpass (180 tests).src/output.rs: the fullenvoutput, with and without a trailing/on the proxy URL.service-account usage's existing test still covers its lines.docs/site/build.py.🤖 Generated with Claude Code