Cherry-pick int0002 IRQF_ONESHOT removal on top of the SCI revert - #607
Open
croos12 wants to merge 1 commit into
Open
Cherry-pick int0002 IRQF_ONESHOT removal on top of the SCI revert#607croos12 wants to merge 1 commit into
croos12 wants to merge 1 commit into
Conversation
Backport stable commit 5938fb0e3285 ("platform/x86: int0002: Remove
IRQF_ONESHOT from request_irq()", upstream f6bc712877f2) on top of the
revert of 7a36b901a6eb ("ACPI: OSL: Use a threaded interrupt handler for
SCI").
The INT0002 GPIO IRQ is typically shared with the ACPI SCI. With the SCI
back on a plain IRQF_SHARED request_irq(), INT0002 must drop IRQF_ONESHOT
or probe fails with a flags mismatch.
Signed-off-by: Connor Roos <croos@nvidia.com>
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
dgsudharsan
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
With the ACPI SCI back on a plain
IRQF_SHAREDrequest_irq(), the INT0002 virtual GPIOdriver — which shares that IRQ line — still requests it with
IRQF_ONESHOT. The mismatchedflags make
request_irq()fail andint0002_vgpiofail to probe.The visible symptom is a boot-time hang: after a successful ONIE install the switch freezes due to the kernel boot not progressing (~30% reproduction on SN5600). Dropping
IRQF_ONESHOTresolves it.How I did it
patches-sonic/platform-x86-int0002-remove-irqf-oneshot.patch, backporting stablecommit
5938fb0e3285("platform/x86: int0002: Remove IRQF_ONESHOT from request_irq()",upstream
f6bc712877f2).patches-sonic/series.How to verify it
int0002_vgpioprobes cleanly —dmesg | grep -i int0002shows noIRQF_SHARED/flags-mismatch error and norequest_irqfailure.grep int0002 /proc/interrupts.Tested branch (Please provide the tested image version)
Description for the changelog
Remove IRQF_ONESHOT from INT0002 request_irq() to fix shared-IRQ flags mismatch