[somewhatabstract]

Stacked on #2708. This adds get_files, the Rust port of checksync's getFiles, and finishes Phase 2 of #2615.

New file_search module, written by me:

• Planning: plan_glob_tasks does the following:

  • expands brace groups;
  • treats ! includes and ! excludes as excludes;
  • collapses repeated slashes and drops leading ./;
  • works out the folder each include walks from.

  expand_folder_pattern turns a folder named without a * into folder/**, as the TypeScript does.

• Walking: walk_glob_folder walks each starting folder once, for all the patterns that start there.

  • It lists regular files only, and doesn't follow links it finds on the way. A pattern's starting folder can be a link.
  • It enters hidden folders only for a pattern folder name that could match one, stops at the depth a pattern without ** allows, and prunes excluded folders.
  • Read errors name the path that failed.

• Results: find_files sorts results as JavaScript sorts strings. get_files loads the ignore files first, then filters with them.

• Matching rules: a pattern matches a path that is exactly its text as well as by glob, so app/[slug]/page.tsx works. Includes match the way fast-glob does by default:

  • by folder;
  • case-sensitively;
  • by whole characters;
  • with wildcards matching no name that starts with ., and never running over . or ...

  Excludes also match names that start with ., as in fast-glob. Absolute excludes are matched against each path's absolute form, as in fast-glob.

glob module, from the clean-room agent:

• Add brace expansion and a dotfile option to the Rust glob module #2708 review points: two commits fold them in. A NUL ends a brace pattern, and the test-table test reports instead of crashing. They also expose brace expansion.
• unicode option: makes ? and bracket sets match one whole character for file search. gitignore stays byte-based, as git is.
• HiddenNames option: replaces the old dot flag. It keeps * and ** off . and .. names for fast-glob matching, so **/one.js no longer matches ../src/one.js. gitignore keeps git's rule. The fastglob-vectors.json overrides for ./.. are now agreements. This also removes the struct_excessive_bools exception.

Deliberate differences, as decided for 12.0.0:

• An exclude always prunes the folders it matches. fast-glob only does so for excludes without wildcards, and never for a pattern's starting folder.
• x/** doesn't match x itself.
• ? is a wildcard in any folder name. fast-glob treats it literally in a folder name before the last one.
• A negated bracket set doesn't match the . that starts a hidden name. micromatch's does.
• A pattern that walks into a file finds nothing. The TypeScript crashes with "not a directory".
• An emoji counts as one character. micromatch counts it as two.

The first four are recorded in file-vectors.json with rust reasons. There are also new vectors for:

• literal paths;
• ! excludes;
• repeated slashes;
• bracket sets and escaped dots on hidden folders;
• .. with wildcard and step-up excludes;
• ?.js against é.js.

Test plan

• The new Rust test tests/file_vectors.rs passes all 46 file vectors. The TypeScript test passes with them too.
• I compared get_files with fast-glob on 3,000 random file trees and patterns. Every difference comes from the deliberate rules above: 44 from the folder rule and 26 from a trailing /**.

---

🤖 Generated with Claude Code

https://claude.ai/code/session_01QjLhVH1NnUc7MzCSYLd8Yn

[changeset-bot]

🦋 Changeset detected

Latest commit: 969a99a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Bundle Report

Bundle size has no change ✅

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3f070b3) to head (969a99a).

Additional details and impacted files

@@                               Coverage Diff                               @@
##           claude/jolly-galileo-72zesp-glob-braces-dot     #2709     +/-   ##
===============================================================================
  Coverage                                       100.00%   100.00%             
===============================================================================
  Files                                              126       154     +28     
  Lines                                             5085      6877   +1792     
  Branches                                          4293      6083   +1790     
===============================================================================
+ Hits                                              5085      6877   +1792     

Flag	Coverage Δ
rust	100.00% <100.00%> (ø)
typescript	100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ecksync-core/src/file_search/absolute_glob_text.rs	100.00% <100.00%> (ø)
...sync-core/src/file_search/bracket_may_match_dot.rs	100.00% <100.00%> (ø)
...checksync-core/src/file_search/collapse_slashes.rs	100.00% <100.00%> (ø)
...sync-core/src/file_search/compile_exclude_globs.rs	100.00% <100.00%> (ø)
...cksync-core/src/file_search/compile_pattern_set.rs	100.00% <100.00%> (ø)
...sync-core/src/file_search/expand_folder_pattern.rs	100.00% <100.00%> (ø)
...sync-core/src/file_search/expand_pattern_braces.rs	100.00% <100.00%> (ø)
...rates/checksync-core/src/file_search/find_files.rs	100.00% <100.00%> (ø)
...crates/checksync-core/src/file_search/get_files.rs	100.00% <100.00%> (ø)
...crates/checksync-core/src/file_search/glob_base.rs	100.00% <100.00%> (ø)
... and 33 more

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f070b3...969a99a. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.