Repository navigation
fix(solid): read a subject typed as deck and group as a deck only - #670
Merged
Merged
Conversation
The catalog's decks and deck groups were read apart, so a subject that fits both shapes was read twice: once as a deck and once as a group of the same URL. The deck list showed it twice, and some moves past it or out of it failed with a raw TypeError instead of the app's own error, because the tree looked nodes up by URL alone. A deck in its own format that was also typed as a group made the whole arrangement read-only. A subject read as a deck is now a deck only; its group type and member links are ignored. The tree also looks a parent up as a group, so a deck of the same URL is never taken for it, and treeChanges refuses a tree that holds a node twice with the deck-tree-changed error. Refs: GHSA-jhx9-xcwf-9jmq
ixuz
enabled auto-merge
November 8, 2026 17:08
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The catalog's decks and deck groups were read separately, so a subject
that fits both shapes was read twice, as a deck and as a group of the
same URL. The deck list showed it twice, and some moves past it or out
of it failed with a raw TypeError instead of the app's own error. A
deck in its own format that was also typed as a group made the whole
arrangement read-only.
A subject read as a deck is now a deck only; its group type and member
links are ignored. The deck tree looks a parent up as a group and a
moved deck up as a deck, so a node of the other kind with the same URL
is never taken for it, and treeChanges refuses a tree that holds a node
twice with the deck-tree-changed error. docs/data-model.md states the
rule.
Refs: GHSA-jhx9-xcwf-9jmq