Repository navigation
fix(application): check a next version's draft for guest-pod links - #669
Merged
Merged
Conversation
A release made a draft is refused when it links to the guest's pod by an IRI, as a guest's draft that does could not be kept. A next version also takes what the documents its release links to say of its series and publisher, and those statements were never checked: a clean release could still bring guest-pod IRIs into a guest's draft, and the guest could not keep their study until they deleted it. The draft a next version makes is now checked as it will be written: when it links to the guest's pod by an IRI other than its own or its subjects', which a copy of it moves, it is refused with releaseLinksGuestPod and nothing is written. The check on the release itself stays as it was. Refs: GHSA-vrq3-87m3-6rgg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A release made into a draft is refused when it links to the guest's pod,
since a guest's draft that does could not be kept. A next version also
takes what the documents its release links to say of its series,
publisher and earlier versions, and those statements were never
checked: a clean release could still bring guest-pod IRIs into a
guest's draft, and the guest could not keep their study until they
deleted it.
The draft a next version makes is now checked as it will be written:
when it links to the guest's pod by an IRI other than its own URL or
its own subjects (which a copy of it moves), it is refused with
releaseLinksGuestPod and nothing is written. The check on the release
itself stays as it was. docs/studio.md and docs/guest-mode.md describe
the rule.
Refs: GHSA-vrq3-87m3-6rgg