Repository navigation
fix(domain): give the instance graph's blank nodes short ids - #666
Merged
Merged
Conversation
The Studio's graph named a blank node by its label joined to its document's address. A label may be as long as a term may be, so the joined id could be longer than V8 hashes all of, and the graph's maps, and the Studio's labels, node index, layout and view, would key many such ids in time growing with the square of their number. Each blank node of a document now gets a number of its own as its id, looked up by the path of its document and its term, never one joined string. The node keeps its term, which the graph still shows as its label. The Studio also counts labels it tells apart by a file's name and a label as a path of the two. The number depends on the documents read before, so the Studio does not use it where it would show or matter: the layout orders blank nodes by their document, then their term, compared apart, so where a cycle breaks still does not depend on unrelated nodes; the node pane shows a blank node's term, not its number; and the search finds a blank node by its term or its document's address. Refs: GHSA-6qgg-9wcf-9vqr
ixuz
enabled auto-merge
November 8, 2026 17:07
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Studio's instance graph named a blank node by its label joined to its
document's address. A label may be as long as a term may be, so the
joined id could get too long to hash quickly, and building, labeling,
laying out and drawing the graph took time that grew with the square
of the number of such nodes.
Each blank node of a document now gets a short number as its id, looked
up by its document and its term as a path, never as one joined string.
The node keeps its term:
cycle breaks still doesn't depend on unrelated nodes;
The Studio also counts the labels it tells apart by a path of file name
and label. docs/deck-library.md and docs/studio.md describe the new ids.
The
node=route parameter of a blank node now holds its number, whichstays valid while the instance's data stays the same.
Refs: GHSA-6qgg-9wcf-9vqr