Repository navigation
Conversation
The instance check and the per-deck check skip each deck's unclaimed documents in any spelling of their address. They did so by comparing every document of the instance with every unclaimed document of every deck, parsing both addresses each time, so the work grew with the square of the decks a catalog names and with their addresses' length. A foreign instance listing many decks whose documents are unclaimed could hold the tab's main thread for long on every open. The unclaimed documents are now brought to the form a request sends once per check, keyed by pieces so a long address hashes in full, and each document of the instance is looked up once. Every spelling of an unclaimed document is still skipped. Refs: GHSA-p55m-36p9-7298
ixuz
enabled auto-merge
November 8, 2026 12:43
ixuz
added this pull request to the merge queue
Nov 8, 2026
Any commits made after this event will not be merged.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 8, 2026
ixuz
added this pull request to the merge queue
Nov 8, 2026
Any commits made after this event will not be merged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The instance check and the per-deck check skip each deck's unclaimed documents in any spelling of their address. They did so by comparing every document of the instance with every unclaimed document of every deck, parsing both addresses each time, so the work grew with the square of the decks a catalog names and with their addresses' length.
docs/validation.mdsays how the comparison is made.Refs: GHSA-p55m-36p9-7298