Repository navigation
fix(guest): refuse outside data that links to the guest's pod - #656
Merged
Merged
Conversation
A release read from the library or a link, a release made a draft and a deck file could carry an address at the guest's pod, such as a card's picture or what it is about. Added to a guest's study, that address is not one of the study's own, so the move leaves it as it is: keeping the study as a new instance then failed on every try, and adding it to an instance refused that deck. Such a release is now refused where it is read, for every user (releaseLinksGuestPod), and an import checks what it keeps before it writes anything. Text the reader reads, such as a card's or what changed in the release, may still name any address. A deck file is refused the same way (deckFileLinksGuestPod), though its deck's and cards' own addresses may be at the guest's pod, as a guest's export has them. When a copied document still names the guest's pod, the move's error now names the guest's deck it belongs to, so the user can tell which deck to leave out. Refs: GHSA-hc3p-fpwj-fvjp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A release read from the library or a link, a release made a draft, and a deck file could carry an address at the guest's pod, such as a card's picture or what it is about. Added to a guest's study, that address is not one of the study's own, so the move leaves it as it is: keeping the study as a new instance then failed on every try, and adding it to an instance refused that deck.
releaseLinksGuestPod), and an import checks what it keeps before it writes anything.deckFileLinksGuestPod), though its deck's and cards' own addresses may be at the guest's pod, as a guest's export has them.guestDeckCopyUrlsLeft), so the user can tell which deck to leave out.docs/guest-mode.md,docs/deck-library.mdanddocs/studio.mddescribe the rule.Refs: GHSA-hc3p-fpwj-fvjp