Skip to content

Internal - Add cel sampler to test config - #588

Open
cleverchuk wants to merge 1 commit into
mainfrom
cc/NH-147277
Open

Internal - Add cel sampler to test config#588
cleverchuk wants to merge 1 commit into
mainfrom
cc/NH-147277

Conversation

@cleverchuk

@cleverchuk cleverchuk commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Gist

Adds cel_sampler to test config. This will help catch any issue with loading the sampler.

Test services data

  1. e-1712644058766987264
  2. e-1712643928659124224
  3. e-1742334541200846848
  4. e-1777406072376840192

Copilot AI lite review requested due to automatic review settings September 1, 2026 19:54
@cleverchuk
cleverchuk requested review from a team as code owners September 1, 2026 19:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a declarative OpenTelemetry SDK configuration file for the smoke-tests/netty-test app, wires it into the Gradle run task via -Dotel.config.file, and bumps the default solarwinds-otel-sdk version used by the test to exercise newer SDK functionality (including CEL-based sampling config).

Changes:

  • Added smoke-tests/netty-test/sdk-config.yaml with resource, SolarWinds distribution settings, OTLP exporter, and sampler configuration.
  • Updated smoke-tests/netty-test/build.gradle.kts to bump the default SDK version and pass -Dotel.config.file=sdk-config.yaml to the app.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
smoke-tests/netty-test/sdk-config.yaml New declarative SDK config used by the netty smoke test run.
smoke-tests/netty-test/build.gradle.kts Bumps test SDK version and wires the new declarative config file into the app JVM args.
Suppressed comments (1)

smoke-tests/netty-test/sdk-config.yaml:36

  • This comment says a "batch" span processor, but the config actually defines a simple span processor. Update the comment to match the configuration to avoid confusion when debugging exporter behavior.
    - # Configure a batch span processor.
      simple:

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread smoke-tests/netty-test/build.gradle.kts Outdated
Comment thread smoke-tests/netty-test/sdk-config.yaml Outdated
Comment thread smoke-tests/netty-test/sdk-config.yaml Outdated
@cleverchuk cleverchuk changed the title Internal - Add sdk-config.yaml and update netty smoke test build configuration Internal - Add cel sampler to test config Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants