Internal - Add cel sampler to test config - #588
Open
cleverchuk wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a declarative OpenTelemetry SDK configuration file for the smoke-tests/netty-test app, wires it into the Gradle run task via -Dotel.config.file, and bumps the default solarwinds-otel-sdk version used by the test to exercise newer SDK functionality (including CEL-based sampling config).
Changes:
- Added
smoke-tests/netty-test/sdk-config.yamlwith resource, SolarWinds distribution settings, OTLP exporter, and sampler configuration. - Updated
smoke-tests/netty-test/build.gradle.ktsto bump the default SDK version and pass-Dotel.config.file=sdk-config.yamlto the app.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| smoke-tests/netty-test/sdk-config.yaml | New declarative SDK config used by the netty smoke test run. |
| smoke-tests/netty-test/build.gradle.kts | Bumps test SDK version and wires the new declarative config file into the app JVM args. |
Suppressed comments (1)
smoke-tests/netty-test/sdk-config.yaml:36
- This comment says a "batch" span processor, but the config actually defines a
simplespan processor. Update the comment to match the configuration to avoid confusion when debugging exporter behavior.
- # Configure a batch span processor.
simple:
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cleverchuk
force-pushed
the
cc/NH-147277
branch
from
September 1, 2026 20:33
1d4e455 to
bd47498
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gist
Adds
cel_samplerto test config. This will help catch any issue with loading the sampler.Test services data