Repository navigation
Conversation
The custom init(from:) skipped the 12 tpmsPressure/tpmsTemp/tpmsBatt fields added in softwiredtech#275, so the WebSocket data source always showed no tyre readings. Defaults match the stored properties (-1 / -100 = no reading). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #275.
CarState's custominit(from:)on iOS skipped the 12 TPMS fields (tpmsPressure*,tpmsTemp*,tpmsBatt*), so a state decoded from JSON (the WebSocket data source) always kept the no-reading defaults and tyre widgets showed nothing.This adds the 12
decodeIfPresentlines with the same defaults as the stored properties (-1 for pressure and battery, -100 for temperature). Every stored property ofCarStateis now decoded; DashKit and comma are unaffected (they buildCarStatefrom the bridge struct).Not compiled locally (no Xcode on this machine); the change mirrors the existing lines next to it.
🤖 Generated with Claude Code