Repository navigation
[android][ios] Expose Tesla ambient lighting to Rive dashboards - #274
Merged
wpmed92 merged 2 commits intoNov 13, 2026
Merged
Conversation
philoh-dev
force-pushed
the
codex/tesla-ambient-lighting
branch
from
November 9, 2026 10:55
ae0c602 to
cb6c361
Compare
wpmed92
requested changes
Nov 13, 2026
wpmed92
left a comment
wpmed92
left a comment
Contributor
There was a problem hiding this comment.
Other than the comments I left, in general the PR is really verbose, please do a pass on this that makes it more concise, especially readme and tests, AmbientLightingBindingTest is not needed. What is needed instead is an in-car confirmation that the PR works.
Decode through the Tesla DBC mappers and expose color, brightness, and availability. Restore the normal iOS telemetry throttle and simplify the docs and tests. Ambient lighting behavior confirmed in-car by the author.
Contributor
Author
|
@wpmed92 addressed your concerns |
Contributor
|
Thanks @philoh-dev it looks really clean now. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only tested on Android on a Fold7 running OneUI 9 (Android 17)