[PPN-SD]

Starting with libcxx-23 transitive headers are being removed from their C++ standard library.

libtool: compile:  clang++ -std=c++11 -DHAVE_CONFIG_H -I. -I../../.. -I./.. -I./../common -I./../crypto -I./../data_mgr -I./../object_st
ore -I./../pkcs11 -I./../session_mgr -O2 -pipe -march=znver2 -frecord-gcc-switches -ftrivial-auto-var-init=zero -Werror=odr -Werror=stri
ct-aliasing -fno-strict-aliasing -D_FILE_OFFSET_BITS=64 -Wall -Wextra -fvisibility=hidden -c Slot.cpp  -fPIC -DPIC -o .libs/Slot.o      
Token.cpp:536:2: error: use of undeclared identifier 'time'         
  536 |         time(&rawtime);
      |         ^~~~
Token.cpp:538:43: error: use of undeclared identifier 'gmtime'
  538 |         strftime(dateTime, 17, "%Y%m%d%H%M%S00", gmtime(&rawtime));
      |                                                  ^~~~~~
2 errors generated.

Summary by CodeRabbit

• Chores
  • Made a small internal maintenance adjustment related to existing time handling. This update does not change the app’s visible features or behavior, and no new user-facing capabilities or fixes are included. There are no changes to how users interact with the app.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

Token.cpp now includes <ctime>. No functions or public declarations changed.

Changes: Token time header

Layer / File(s)	Summary
Add time header src/lib/slot_mgr/Token.cpp	The file includes <ctime>. No functions or public declarations changed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: jschlyter

Merge Risk: Minimal · up to 25084

The missing time header is added without changing runtime behavior. No merge-blocking risk is identified.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title describes the missing header added for libcxx-23.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 4e78db21-7af0-4736-bdb8-234f40ddc151

Commits

Reviewing files that changed from the base of the PR and between e59a00d and 250842d.

Files selected for processing: 1

• src/lib/slot_mgr/Token.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.