Write CBOR strings from compact Latin-1 storage - #1326
Merged
adwsingh merged 1 commit intoAug 14, 2026
Conversation
adwsingh
force-pushed
the
adwsingh/cbor-compact-string-access
branch
from
August 14, 2026 16:05
8ffd880 to
bb852bf
Compare
mtdowling
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What behavior changes?
CBOR now reads compact strings from their Latin-1 backing array. ASCII is bulk-copied, while non-ASCII Latin-1 bytes are expanded directly to UTF-8.
Why is this change needed?
This avoids repeated
charAtaccess and the deprecated string copy path used by the common CBOR case.How was this validated?
Ran the CBOR tests with compact access enabled and forcibly disabled, plus Spotless checks.
What should reviewers focus on?
The ASCII copy path, Latin-1 expansion, and unchanged UTF-16 fallback.
Additional Links
Part of stack #1325.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.