Write JSON strings by copying the Latin-1 array in one validate-and-copy pass - #1324
Merged
adwsingh merged 2 commits intoAug 14, 2026
Merged
Conversation
adwsingh
force-pushed
the
adwsingh/serde-perf
branch
2 times, most recently
from
August 14, 2026 11:19
1073fd4 to
fe55153
Compare
adwsingh
force-pushed
the
adwsingh/serde-perf
branch
from
August 14, 2026 12:28
fe55153 to
8a5bbb1
Compare
adwsingh
force-pushed
the
adwsingh/serde-perf
branch
2 times, most recently
from
August 14, 2026 13:27
bc2289e to
97b56d4
Compare
adwsingh
force-pushed
the
adwsingh/serde-perf
branch
from
August 14, 2026 13:50
97b56d4 to
2f96b20
Compare
adwsingh
force-pushed
the
adwsingh/serde-perf
branch
2 times, most recently
from
August 14, 2026 15:48
e125374 to
5c79951
Compare
adwsingh
force-pushed
the
adwsingh/serde-perf
branch
from
August 14, 2026 16:05
2a082da to
e26682e
Compare
adwsingh
marked this pull request as ready for review
August 14, 2026 16:06
mtdowling
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What behavior changes?
Compact ASCII strings are now validated and copied from their backing Latin-1 array in one pass. Other strings and unsupported runtimes keep the character-based fallback.
Why is this change needed?
This removes repeated
charAtaccess from the common JSON string write path without requiring JVM flags.How was this validated?
Added
CompactStringAccessand JSON write tests, forced-fallback coverage, andJsonStringWriteBenchmark.What should reviewers focus on?
The runtime access fallback, word-at-a-time validation, and partial-copy retry behavior.
Additional Links
Part of stack #1325.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.