Confirm the in-order JSON field name guess with one masked word compare - #1323
Merged
adwsingh merged 3 commits intoAug 14, 2026
Merged
Conversation
adwsingh
force-pushed
the
adwsingh/json-field-name-word-compare
branch
2 times, most recently
from
August 14, 2026 11:19
d23c789 to
bef1171
Compare
adwsingh
force-pushed
the
adwsingh/json-field-name-word-compare
branch
2 times, most recently
from
August 14, 2026 13:04
1c67eaa to
cc426ad
Compare
adwsingh
force-pushed
the
adwsingh/json-field-name-word-compare
branch
from
August 14, 2026 13:27
cc426ad to
391ed17
Compare
adwsingh
force-pushed
the
adwsingh/json-field-name-word-compare
branch
from
August 14, 2026 13:50
391ed17 to
cc1238a
Compare
adwsingh
force-pushed
the
adwsingh/json-field-name-word-compare
branch
2 times, most recently
from
August 14, 2026 15:48
3944dc9 to
a8e49c2
Compare
adwsingh
marked this pull request as ready for review
August 14, 2026 16:05
mtdowling
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What behavior changes?
Short JSON field names in their expected order are now checked with one masked word comparison. Longer or out-of-order names keep the existing lookup path.
Why is this change needed?
Generated payloads usually keep schema order, so the common field lookup can avoid a byte loop and
Arrays.equals.How was this validated?
Added ordered, out-of-order, short-name, and fallback tests plus
JsonFieldNameDeserializeBenchmark.What should reviewers focus on?
The quote-inclusive packed names, length mask, and fallback behavior.
Additional Links
Part of stack #1325.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.