Repository navigation
Escape terminal controls in setup path output - #210
Merged
Merged
Conversation
Skill directories and a missing Herdr plugin root were printed raw, so a control character in those paths could reach the terminal. Show them with the same visible escapes as the rest of setup output. Co-authored-by: Saeed <smarzban@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
smarzban
marked this pull request as ready for review
October 15, 2026 19:38
smarzban
added a commit
that referenced
this pull request
Oct 15, 2026
… keys) # Conflicts: # CHANGELOG.md # site/public/board-demo.js # site/src/content/docs/docs/keys.md # site/test/site.test.mjs # src/ui/input.rs # src/ui/render.rs # tests/quick_add_capture.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsk setupprinted some paths without the terminal-control escaping used everywhere else. A skill directory (fromHOMEor an agent directory override) and a previous Herdrplugin_rootcould contain C0/C1 characters and those bytes were written straight to the terminal. Batch setup rows, the interactive agent list,tsk setupguidance, and the "previous registration is gone" notice now run those paths through the same visible-escape filter as a single skill write.Test plan
cargo fmt --checkcargo clippy --all-targets -- -D warningscargo testcd site && npm ci && npm test && npm run build(ifsite/changed)Regression tests cover a skill path with an OSC sequence in batch setup output, a home directory containing that sequence in setup guidance and the interactive agent list, and a missing Herdr plugin root containing that sequence. Each test fails if the path is printed raw. Live Herdr smoke was not run (
HERDR_ENVis unset). No site files changed.