Fix float to int deprecation in "is odd by" / "is even by" operators - #1210
Open
h-marumoto wants to merge 1 commit into
Open
h-marumoto wants to merge 1 commit into
h-marumoto wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1208
Hi!
is [not] odd by/is [not] even bycompile to(1 & $a / $b).When the division has a remainder, the bitwise AND triggers "Implicit conversion from float to int loses precision" on PHP 8.1+.
The division result is now cast to int explicitly (
(1 & (int)($a / $b))), which matches the implicit truncation PHP was already doing, so template output is unchanged.Thank you!