fix(maps): stack overflow from map.resize() inside moveend handler - #164
Merged
Conversation
Promote to production: fix blank map after detect-my-location
Promote to production: Cron Expression tool
Promote to production: reverse cron (natural language → expression)
The previous fix called map.resize() synchronously inside the moveend handler. MapLibre internally calls constrainInternal during resize, which fires another moveend within the same call stack → infinite recursion → RangeError: Maximum call stack size exceeded. Fix: guard flag + requestAnimationFrame so resize() runs after the current call stack clears. The flag ensures at most one pending resize at a time, and rAF breaks the synchronous recursion path entirely. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
goodwebtools | 37407af | Aug 07 2026, 08:55 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Previous fix (PR #158) called
map.resize()synchronously insidemoveend. MapLibre callsconstrainInternalduring resize, which re-firesmoveendwithin the same call stack →RangeError: Maximum call stack size exceeded.Fix
Guard flag +
requestAnimationFrame: resize deferred to the next frame, breaking the synchronous recursion. Flag prevents queuing more than one resize at a time.Test plan