Skip to content

HTML API: Append a style declaration before trailing whitespace - #108

Open
sirreal wants to merge 2 commits into
css-token-style-attr-processorfrom
css-api/style-append-trailing-whitespace
Open

sirreal wants to merge 2 commits into
css-token-style-attr-processorfrom
css-api/style-append-trailing-whitespace

Conversation

@sirreal

@sirreal sirreal commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Caution

This is a work in progress draft and is not ready for any serious review.

WP_HTML_Style_Attribute_Processor::append_declaration() chose its separator from the text before any trailing whitespace, but inserted the declaration after that whitespace. A style ending in whitespace then got a doubled space or a space before the ;:

Style Before After
margin: 5px; margin: 5px; padding: 10px; same
margin: 5px;␠ margin: 5px;␠␠padding: 10px; margin: 5px; padding: 10px;␠
margin: 5px␠ margin: 5px␠; padding: 10px; margin: 5px; padding: 10px;␠

(␠ marks a space.) The CSS was valid before; only its text changes.

A whitespace token at the end of the style is now the insertion point, so the trailing whitespace stays at the end and the existing text keeps its bytes. Trailing whitespace inside another token stays before the appended declaration, because it is part of that token: an unterminated string (font-family: "a␠ becomes font-family: "a␠"; padding: 10px;), an unterminated url(, or an escaped space (a\␠). The spec's append section states the rule.

Tests cover each case. The html-api and css-api groups pass (3237 tests), and PHPCS and PHPStan are clean.

Depends on WordPress#14782.

Trac ticket: TBD

Use of AI Tools

AI assistance: Yes
Tools: Claude Code
Models: Claude Opus 5.5
Used for: implementation, tests and this description.


This pull request is for code review only. Keep other discussion in the Trac ticket. Do not merge. See GitHub Pull Requests for Code Review in the Core Handbook.

append_declaration() chose its separator from the text before any
trailing whitespace but inserted the declaration after it. A style
ending in whitespace then got a doubled space or a space before the
separator:

  margin: 5px;   ->  margin: 5px;  padding: 10px;
  margin: 5px    ->  margin: 5px ; padding: 10px;

A whitespace token at the end of the style is now the insertion point,
so the separator follows the text before it and the whitespace stays
after the appended declaration. Trailing whitespace that belongs to
another token, such as an unterminated string or an escaped space, is
part of that token, and the declaration is still appended after it.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant