Repository navigation
Conversation
append_declaration() chose its separator from the text before any trailing whitespace but inserted the declaration after it. A style ending in whitespace then got a doubled space or a space before the separator: margin: 5px; -> margin: 5px; padding: 10px; margin: 5px -> margin: 5px ; padding: 10px; A whitespace token at the end of the style is now the insertion point, so the separator follows the text before it and the whitespace stays after the appended declaration. Trailing whitespace that belongs to another token, such as an unterminated string or an escaped space, is part of that token, and the declaration is still appended after it.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
…nd-trailing-whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This is a work in progress draft and is not ready for any serious review.
WP_HTML_Style_Attribute_Processor::append_declaration()chose its separator from the text before any trailing whitespace, but inserted the declaration after that whitespace. A style ending in whitespace then got a doubled space or a space before the;:margin: 5px;margin: 5px; padding: 10px;margin: 5px;␠margin: 5px;␠␠padding: 10px;margin: 5px; padding: 10px;␠margin: 5px␠margin: 5px␠; padding: 10px;margin: 5px; padding: 10px;␠(
␠marks a space.) The CSS was valid before; only its text changes.A whitespace token at the end of the style is now the insertion point, so the trailing whitespace stays at the end and the existing text keeps its bytes. Trailing whitespace inside another token stays before the appended declaration, because it is part of that token: an unterminated string (
font-family: "a␠becomesfont-family: "a␠"; padding: 10px;), an unterminatedurl(, or an escaped space (a\␠). The spec's append section states the rule.Tests cover each case. The
html-apiandcss-apigroups pass (3237 tests), and PHPCS and PHPStan are clean.Depends on WordPress#14782.
Trac ticket: TBD
Use of AI Tools
AI assistance: Yes
Tools: Claude Code
Models: Claude Opus 5.5
Used for: implementation, tests and this description.
This pull request is for code review only. Keep other discussion in the Trac ticket. Do not merge. See GitHub Pull Requests for Code Review in the Core Handbook.