[Shaman] Fix Flametongue Weapon buff never applying - #11749
Open
ahomescu wants to merge 2 commits into
Open
Conversation
The buff was created from find_class_spell( "Flametongue Weapon" ), which returns not_found since the spell is now a talent, leaving the buff with a zero trigger chance. The assisted combat APL gates the imbue on buff.flametongue_weapon.down, so it recast the imbue every GCD forever. Use the actual imbue aura (319778) instead.
Match the Windfury Weapon buff setup so the buff cannot trigger when the Flametongue Weapon talent is not selected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to sim my elemental shaman Traxxen with
use_blizzard_action_list=1on raidbots after I picked Flametongue Weapon produced some really low numbers (7k DPS), see the report at https://www.raidbots.com/simbot/report/2GQFRwTqKp2aQzCMbQog1s. All it did was cast that buff over and over the whole fight.This patch fixes the issue. I tested a local build and it now correctly simulates the fight, and DPS went up to around 60k. I suspect this might also solve the really low numbers for enhancement at https://www.noxxic.com/wow/sims/enhancement-shaman/one-button-alt. Their build takes this talent (but not the elemental one, for some reason).