feat(code): cli sandboxes, enterprise timeouts, secrets projections, resolver lift - #6247
feat(code): cli sandboxes, enterprise timeouts, secrets projections, resolver lift#6247icecrasher321 wants to merge 11 commits into
Conversation
…lver # Conflicts: # apps/sim/components/settings/navigation.test.ts # apps/sim/components/settings/navigation.ts # apps/sim/providers/index.test.ts
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 35640005 | Triggered | Generic Password | 1a7c79b | apps/desktop/src/main/browser-import/import-service.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryHigh Risk Overview Function execution gains Shell as a remote language, Python as real modules ( Secrets move through a shared compiler: Async workflow policy adds optional Reviewed by Cursor Bugbot for commit 93c6320. Configure here. |
Greptile SummaryThe PR centralizes workflow placeholder and secret resolution while extending remote Function sandboxes and execution-timeout policy.
Confidence Score: 5/5The PR appears safe to merge based on the eligible follow-up review scope. No blocking failure remains within the displayed prior-thread scope.
|
| Filename | Overview |
|---|---|
| apps/sim/executor/variables/resolver.ts | Centralizes workflow value and secret resolution for executor consumers. |
| apps/sim/executor/utils/resolved-secret-content-projection.ts | Adds bounded, non-mutating projection of resolved secret values from model- and log-visible structures. |
| apps/sim/lib/execution/remote-sandbox/resolve.ts | Resolves sandbox specifications, provider strategy, managed CLI environments, and runtime dependency provisioning. |
| apps/sim/lib/execution/remote-sandbox/cli-tools.server.ts | Defines pinned server-side installation and verification recipes for managed CLIs. |
| apps/sim/lib/core/execution-limits/types.ts | Extends execution-limit resolution to support enterprise policy and request-level timeout caps. |
| apps/sim/lib/execution/preprocessing.ts | Applies centralized timeout and resolver behavior during workflow preprocessing. |
| packages/db/schema.ts | Extends persisted sandbox and enterprise metadata contracts for CLI selections and timeout configuration. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Trigger[API / Webhook / Schedule / Table] --> Policy[Resolve async timeout policy]
Policy --> Job[Background execution job]
Job --> Resolver[Central placeholder and secret resolver]
Resolver --> Engine[Workflow executor]
Engine --> Function[Function block]
Function --> Sandbox[Remote sandbox resolver]
Sandbox --> Spec[Content-addressed sandbox spec]
Spec --> E2B[E2B prebuilt image]
Spec --> Daytona[Daytona runtime provisioning]
E2B --> Runtime[JavaScript / Python / Shell]
Daytona --> Runtime
CLI[Managed CLI registry] --> Spec
Secrets[Authorized secret catalog] --> Resolver
Resolver --> Functional[Functional runtime data]
Resolver --> Projection[Log and model projection]
Projection --> Logs[Protected logs]
Projection --> Model[Protected model requests]
Reviews (9): Last reviewed commit: "Merge remote-tracking branch 'origin/sta..." | Re-trigger Greptile
|
@cursor review |
|
@cursor review |
|
@cursor review |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e3f33d1. Configure here.
|
@cursor review |
|
@cursor review |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6a257db. Configure here.
…lver # Conflicts: # apps/sim/background/schedule-execution.test.ts # apps/sim/background/schedule-execution.ts # apps/sim/lib/copilot/chat/workspace-context.ts
|
@cursor review |
Summary
Type of Change
Testing
Tested manually
Checklist