Skip to content

Add tests for LT-22576 - #1052

Draft
imnasnainaec wants to merge 5 commits into
mainfrom
LT-22576-tests
Draft

Add tests for LT-22576#1052
imnasnainaec wants to merge 5 commits into
mainfrom
LT-22576-tests

Conversation

@imnasnainaec

@imnasnainaec imnasnainaec commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Quick Summary

Tests requested by #1051 author, generated by Claude.

Devin review: https://app.devin.ai/review/sillsdev/FieldWorks/pull/1052

CI-ready checklist

  • Commit messages follow .github/commit-guidelines.md (subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).
  • No whitespace warnings locally:
    git fetch origin
    git log --check --pretty=format:"---% h% s" origin/<base>..
    git diff --check --cached
  • Builds/tests pass locally (or I've run the CI-style build via Bash script or MSBuild).
  • If this is core-developer AI-assisted work, I followed Docs/workflows/ai-pr-workflow.md and ran pr-preflight or the equivalent branch-readiness review before requesting review.
  • For any Src/** folders touched, corresponding AGENTS.md files are updated or explicitly confirmed still accurate.

This change is Reviewable

aror92 and others added 5 commits August 7, 2026 13:18
Add method to RuleFormulaControl to check if NC is user defined.

Update OnDisplayContextSetFeatures in RuleFormulaSlice to display
the set phonological features option only if the NC uses features
and is not user-defined.

Change-Id: Ifc34b73348ef37b49f064f8840d6ad6502dabfb9
- Handle case when NC has no name in default WS
- Add check for if NC is FeatureBased

Change-Id: Ie673bf1e936a3aee499e871fe73b27f4d57c2de8
Change-Id: I92fd4373ed02bcdd66895acb149e01c5cd60190a
Change-Id: I136b89652ff24e69310ba9189b8dea6594a68af6
Cover IsFeatureBasedNCNameUserDefined and RuleFormulaSlice.OnDisplayContextSetFeatures
for user-named, auto-generated, unnamed, segment-based, iteration-wrapped, and
empty-selection contexts. The test control overrides GetCmObject, the extension point
concrete rule controls already implement, so the selection-to-context logic under test
is the production code.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@imnasnainaec
imnasnainaec requested a review from aror92 August 7, 2026 19:34
Base automatically changed from LT-22576 to main August 7, 2026 19:37
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

⚠️ Commit Message Format Issues ⚠️

commit 086024dd96:
3: B1 Line exceeds max length (86>80): "Cover IsFeatureBasedNCNameUserDefined and RuleFormulaSlice.OnDisplayContextSetFeatures"
5: B1 Line exceeds max length (85>80): "empty-selection contexts. The test control overrides GetCmObject, the extension point"
6: B1 Line exceeds max length (86>80): "concrete rule controls already implement, so the selection-to-context logic under test"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants