Add tests for LT-22576 - #1052
Draft
imnasnainaec wants to merge 5 commits into
Draft
Conversation
Add method to RuleFormulaControl to check if NC is user defined. Update OnDisplayContextSetFeatures in RuleFormulaSlice to display the set phonological features option only if the NC uses features and is not user-defined. Change-Id: Ifc34b73348ef37b49f064f8840d6ad6502dabfb9
- Handle case when NC has no name in default WS - Add check for if NC is FeatureBased Change-Id: Ie673bf1e936a3aee499e871fe73b27f4d57c2de8
Change-Id: I92fd4373ed02bcdd66895acb149e01c5cd60190a
Change-Id: I136b89652ff24e69310ba9189b8dea6594a68af6
Cover IsFeatureBasedNCNameUserDefined and RuleFormulaSlice.OnDisplayContextSetFeatures for user-named, auto-generated, unnamed, segment-based, iteration-wrapped, and empty-selection contexts. The test control overrides GetCmObject, the extension point concrete rule controls already implement, so the selection-to-context logic under test is the production code. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
commit 086024dd96: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick Summary
Tests requested by #1051 author, generated by Claude.
Devin review: https://app.devin.ai/review/sillsdev/FieldWorks/pull/1052
CI-ready checklist
.github/commit-guidelines.md(subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).If this is core-developer AI-assisted work, I followedDocs/workflows/ai-pr-workflow.mdand ranpr-preflightor the equivalent branch-readiness review before requesting review.Src/**folders touched, correspondingAGENTS.mdfiles are updated or explicitly confirmed still accurate.This change is