Skip to content

Update three LDML files from SLDR - #1047

Merged
papeh merged 1 commit into
mainfrom
update/ldml
Aug 10, 2026
Merged

Update three LDML files from SLDR#1047
papeh merged 1 commit into
mainfrom
update/ldml

Conversation

@papeh

@papeh papeh commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Quick Summary

CI-ready checklist

  • Commit messages follow .github/commit-guidelines.md (subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).
  • No whitespace warnings locally:
    git fetch origin
    git log --check --pretty=format:"---% h% s" origin/<base>..
    git diff --check --cached
  • Builds/tests pass locally (or I've run the CI-style build via Bash script or MSBuild).
  • If this is core-developer AI-assisted work, I followed Docs/workflows/ai-pr-workflow.md and ran pr-preflight or the equivalent branch-readiness review before requesting review.
  • For any Src/** folders touched, corresponding AGENTS.md files are updated or explicitly confirmed still accurate.

Notes for reviewers (optional)


This change is Reviewable

@papeh
papeh marked this pull request as ready for review August 6, 2026 19:20

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? For attribute order? Ok.
:lgtm:

@jasonleenaylor reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.

@papeh

papeh commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Really. Each time I run a localize build, the updated LDML files hang out in my list of files to stage until I revert them, which lasts until I run my next localize build. Thanks for understanding 😁

@papeh

papeh commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@jasonleenaylor, on second thought, perhaps we should remove them all and .gitignore them. SIL owns SLDR, so we'd get notice if it was going away, so we don't gain anything by caching these. It could be another download step in developer builds, and I could further consider consequences, but that may be the thing to do.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   12m 1s ⏱️ + 1m 11s
5 761 tests ±0  5 680 ✅ ±0  81 💤 ±0  0 ❌ ±0 
5 770 runs  ±0  5 689 ✅ ±0  81 💤 ±0  0 ❌ ±0 

Results for commit ceabe66. ± Comparison against base commit 8dd2468.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.44%. Comparing base (8dd2468) to head (ceabe66).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   36.43%   36.44%           
=======================================
  Files        1354     1354           
  Lines      295676   295676           
  Branches    40223    40223           
=======================================
+ Hits       107742   107756   +14     
+ Misses     158661   158645   -16     
- Partials    29273    29275    +2     

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@papeh
papeh merged commit 41bf33b into main Aug 10, 2026
6 of 7 checks passed
@papeh
papeh deleted the update/ldml branch August 10, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants