Update three LDML files from SLDR - #1047
Conversation
jasonleenaylor
left a comment
There was a problem hiding this comment.
Really? For attribute order? Ok.
@jasonleenaylor reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.
|
Really. Each time I run a localize build, the updated LDML files hang out in my list of files to stage until I revert them, which lasts until I run my next localize build. Thanks for understanding 😁 |
|
@jasonleenaylor, on second thought, perhaps we should remove them all and .gitignore them. SIL owns SLDR, so we'd get notice if it was going away, so we don't gain anything by caching these. It could be another download step in developer builds, and I could further consider consequences, but that may be the thing to do. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1047 +/- ##
=======================================
Coverage 36.43% 36.44%
=======================================
Files 1354 1354
Lines 295676 295676
Branches 40223 40223
=======================================
+ Hits 107742 107756 +14
+ Misses 158661 158645 -16
- Partials 29273 29275 +2 🚀 New features to boost your workflow:
|
Quick Summary
CI-ready checklist
.github/commit-guidelines.md(subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).Docs/workflows/ai-pr-workflow.mdand ranpr-preflightor the equivalent branch-readiness review before requesting review.Src/**folders touched, correspondingAGENTS.mdfiles are updated or explicitly confirmed still accurate.Notes for reviewers (optional)
This change is