LT-22652: Automatically update strings in Crowdin - #1046
Conversation
Update Crowdin source strings as soon as they are updated in FLEx. Doing so requires Crowdin access, and developers frequently forget. FUTURE WORK: automate list export
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1046 +/- ##
=======================================
Coverage 33.10% 33.10%
=======================================
Files 1201 1201
Lines 277959 277959
Branches 37130 37130
=======================================
+ Hits 92018 92019 +1
Misses 158146 158146
+ Partials 27795 27794 -1 🚀 New features to boost your workflow:
|
and build Release (not that it matters, but it looks consistent)
In case strings diverge and we don't remember to remove the branch from crowdin.json when creating a branch for a patch on stable. This will prevent stable strings overwriting latest strings.
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on papeh).
.github/workflows/patch-installer-cd.yml line 119 at r1 (raw file):
ref: ${{ github.event.inputs.lcm_ref || 'master' }} fetch-depth: 0 path: 'Localizations/LCM'
In the workflow we decided to clone LCM into the Localizations folder (since that is the only reason we needed it) devin caught that the uploadUpdatesForTranslation task deletes that folder. Doing this before the build will make the localization build fail, it could be done at the end though.
|
I thought Devin was being silly. Silly me. Unfortunately, deleting the actual LCM repo at the beginning of CopyLcmResxFiles will also prevent these strings from being uploaded. The uploadUpdatesForTranslation and Localize targets expect a different directory structure in LCM, so we'll have to rename one. Renaming the destination of CopyLcmResxFiles would break our structure in Crowdin, so we have to move the repository. We could call it liblcm or lcmrepo. We want to upload sources before the build so that, if any strings have breaking changes, the build still succeeds the first time. |
Update Crowdin source strings as soon as they are updated in FLEx. Doing so requires Crowdin access, and developers frequently forget.
FUTURE WORK: automate list export
CI-ready checklist
.github/commit-guidelines.md(subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).This change is