Emit typed Playwright modules for Sightkick tools and views - #31
Draft
chiplay wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Chip Lay <chiplay@mac.com>
Signed-off-by: Chip Lay <chiplay@mac.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compile Sightkick tools into a typed Playwright module:
This emits
app.mjsand NodeNext-compatibleapp.d.mts.createSightkick(page)exposes typed tool calls and view waits against a caller-owned Playwright Page. The executor reuses existing query and extraction semantics and performs trusted input, preserving guards, optional steps, structured returns, and guidance. Default JSON IR and stored-plan hashes remain unchanged.docs/playwright.mddocuments usage, execution behavior, and supported APIs. Includes a minor changeset and CI checks for the embedded executor.Validation
go vet -tags e2e ./...passed.